LibWeb/CSS: Insert whitespace between tokens in serialized UnresolvedSV

Otherwise, `margin: var(--foo) var(--bar)` would be wrongly serialized as `margin: var(--foo)var(--bar)`
LadybirdBrowser · Oct 15, 2024 · 24a7d98 · 24a7d98
1 parent 9b5d0ae
commit 24a7d98
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/Tests/LibWeb/Text/expected/css/attr-serialization.txt b/Tests/LibWeb/Text/expected/css/attr-serialization.txt
@@ -6,3 +6,4 @@ attr(foo string)
 attr( foo string )
 attr(foo string, "fallback")
 attr( foo string , "fallback" )
+attr(foo) attr(bar) attr(baz)
diff --git a/Tests/LibWeb/Text/input/css/attr-serialization.html b/Tests/LibWeb/Text/input/css/attr-serialization.html
@@ -18,5 +18,6 @@
         serialize('attr(foo string, "fallback")');
         // FIXME: This should produce `attr(foo string, "fallback")` but doesn't yet.
         serialize('attr(  foo   string  ,   "fallback"  )');
+        serialize('  attr(foo)     attr(bar) attr(baz)  ');
     });
 </script>
diff --git a/Userland/Libraries/LibWeb/CSS/StyleValues/UnresolvedStyleValue.cpp b/Userland/Libraries/LibWeb/CSS/StyleValues/UnresolvedStyleValue.cpp
@@ -17,10 +17,7 @@ String UnresolvedStyleValue::to_string() const
     if (m_original_source_text.has_value())
         return *m_original_source_text;
 
-    StringBuilder builder;
-    for (auto& value : m_values)
-        builder.append(value.to_string());
-    return MUST(builder.to_string());
+    return MUST(String::join(' ', m_values));
 }
 
 bool UnresolvedStyleValue::equals(CSSStyleValue const& other) const