LibWeb: Start implementation of rendering tabs according to tab-size #1691
+158
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalenikaliaksandr
requested changes
Oct 9, 2024
|
Please add a layout test for this change. |
|
I will say this is just a start, the glyphs don't align pixel perfectly so I suppose I've gone wrong with some rounding or something somewhere. Thought it would be good to get this PR open to gauge the direction of how this implantation could look with some review. |
Will do. |
kostyafarber
force-pushed
the
start-implementation-of-tab-stop
branch
3 times, most recently
from
2394e87
to
89c19ae
Compare
kostyafarber
force-pushed
the
start-implementation-of-tab-stop
branch
from
89c19ae
to
4df5fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.