Meta: Added an HTTP echo server to help with testing Browser JS #1801
+423
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to simulate HTTP responses from Browser JS tests. Instead of using hacks like data URLs to "load" external data, we can now generate an actual HTTP response that contains arbitrary headers, body, and has a defined response delay. Run the server: python ./Meta/dev-echo-server.py -d ./Tests Visit http://localhost:8000 for usage information.
The test server will be started and backgrounded before the LibWeb suite of tests runs. This makes it possible to load static files in ./Tests/ using http://localhost:8000/static/path-to-file. If you'd like to run a LibWeb test outside of the harness, (ie by loading the HTML file from disk directly in the browser) you will want to first start the http-test-server by hand: > python ./Meta/http-test-server.py -d ./Tests
The example shows how to write a test that depends on custom HTTP headers in the response. This will be useful for testing browser JS that depends on how Ladybird processes response headers, eg CORS headers like Access-Control-Allow-Origin and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to simulate HTTP responses from Browser JS tests. Instead of using hacks like data URLs to "load" external data, we can now generate an actual HTTP response that contains arbitrary headers, body, and has a defined response delay.
Run the server, serving all files in ./Tests at http://localhost:8000/static/:
Visit http://localhost:8000 for usage information.