LibWeb: Implement enough of BaseAudioContext.decodeAudioData() to get ZType to work #1802
+161
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
force-pushed
the
libweb-audiocontext-decodeaudiodata
branch
from
7a53682
to
6837221
Compare
This opens up the code path for the `ArrayBuffer` type, which can now be used as a method argument.
We need these steps to be available for the yet to be implemented `BaseAudioContext.decodeAudioData()`.
This opens up the possibility of easier memory management in future changes.
Implement just enough steps to get https://zty.pe/ working! :^)
gmta
force-pushed
the
libweb-audiocontext-decodeaudiodata
branch
from
6837221
to
786062c
Compare
awesomekling
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZType was not getting some callback invocations in order to get past the loading screen, which it now does! It's very playable, but still needs some performance improvements to run smoothly.