LibWeb: Parse the rotate css property #1823
Conversation
| Angle m_angle; | ||
| FloatVector3 m_rotation_vector; |
There was a problem hiding this comment.
Let's not add new places that don't support calc(). Keep the angle and axis in CSSStyleValue form - maybe the axis can always be 3 values if that's the most convenient.
|
|
||
| namespace Web::CSS { | ||
|
|
||
| class RotationStyleValue : public CSSUnitValue { |
There was a problem hiding this comment.
I don't think it makes sense for this to be a CSSUnitValue. You can't do arithmetic on it.
| auto const& other_angle = other.as_rotation(); | ||
| return m_angle == other_angle.m_angle; |
| if (tokens.remaining_token_count() == 1) { | ||
| auto transaction = tokens.begin_transaction(); | ||
| if (auto keyword = parse_keyword_value(tokens)) { | ||
| if (keyword->to_keyword() == Keyword::None) { | ||
| transaction.commit(); | ||
| return keyword; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We have a helper for this now: parse_all_as_single_keyword_value(tokens, Keyword::None).
| if (auto angle = parse_angle_value(tokens)) { | ||
| // FIXME: Handle calc() | ||
| if (angle->is_angle()) | ||
| return RotationStyleValue::create(angle->as_angle().angle(), 0, 0, 1); | ||
| } |
There was a problem hiding this comment.
The [ x | y | z | <number>{3} ] && <angle> form can have the <angle> first, (any || or && in the grammar means it happens in any order,) which this would parse incorrectly.
| } | ||
|
|
||
| // [ x | y | z ] && <angle> | ||
| if (tokens.remaining_token_count() == 2) { |
There was a problem hiding this comment.
This branch also needs to handle either order.
| // <number>{3} && <angle> | ||
| if (tokens.remaining_token_count() == 4) { |
There was a problem hiding this comment.
Order again. At least you the angle is either at the start or the end, not mixed in with the numbers. 😅
Adds support for parsing the rotate property