LibWeb: Handle calculations without a context better #1827
Merged
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a test for what this fixes? |
stelar7
force-pushed
the
no-context-length-calc
branch
from
f4070ad
to
f8f32e8
Compare
Added a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dont always have a valid context when trying to resolve a calculation, this mitigates that somewhat
I'm not sure if this is the correct fix, since we should(?) have a context at this point, but it stops it from crashing atleast
Fixes a crash on https://wpt.live/css/css-values/acos-asin-atan-atan2-computed.html after we parse the rotate property