-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VS2022 support #6
Conversation
Migrated package.config to PackageReference. Remove application signature to be able to use the IniWrapper package. Some packages is no longer needed as Microsoft.VisualStudio.SDK contaions most assets.
Fix issue logging from non UI threads.
@LaggAt hello! Kindly, could you review/merge this? We'd appreciate it, if you make it possible to use the extension in Visual Studio 2022 |
I'm sorry, I didn't see that earlier. for the key file (.snk) I think we should add a new key as github secret, so that noone is able to release a modified assembly signed by us and causes issues. Thoughts on that? Thanks for your work, I'll try to find some hours for a review/test. |
add changelog push testing version to 1.9 (stable VS2022 Support should be 2.0)
I merged it into master + testing, to have an appveyor.com build to test in my environment. If you want to test with me, vsix file is here: |
@LaggAt thanks! version":"v0.11.0 (rust) I can not investigate more to provide details. But I've read, Rust implementation is the default choice for the future and is 2 years in use by developers already. |
Also I see, stats for top editor files/projects are not accurate, probably. But I don't really know how it's counting, to make any assumptions on it. For instance, I edited a file for at least 20 sec, but metrics doesn't increment, I've tried several times. |
yes, metrics are strange now. Did have it running the whole day while working and have some seconds tracked. About the Rust version: |
Well, after considering the efforts necessary, it might still be the better option to continue on the out-of-proc variant here: They are in phase two now since some days and feature remote UI: Still much of reading, to decide where to go further. |
Well, another thought is to abandon the 2017/2019 code base and continue on the out-of-proc model here: Just pushed what is working so far ... no UI, some Console logs, pushing data works, some bugs probably. |
@LaggAt thanks for your attention and efforts! I really appreciate it. Also @DarkOoze - my respect for your Pull Request. I'm happy to have this extension and enrich ActivityWatcher metrics [when this extension will be operational =)]. I believe, it's better to keep moving with the latest/neweset VS extension-writing model (If I really get your posts right, it's late night for me). IMHO, I don't mind you to drop VS 2017/2019 support also, if it's hard to support both approaches of writing extensions or any other time/energy consuming reason.
If I could help... But it seems it's up to you to decide on next steps. |
Well, support for up to 2019 is there anyway, using the latest stable here. The new model is just nicer, and the code is much better than the first VS extension ever written by me. Think I will investigate on this weekend. |
Update to the latest SDK package.
Some refactoring was needed on some of the async part.