Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Decoupling UA SDKs from hardhat deploy #869

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

janjakubnanista
Copy link
Contributor

In this PR

  • The constructors of and factories for the UA SDKs are modified to accept a provider and an ABI. It is still possible to pass a custom ABI through, as demonstrated by the updated example for custom SDK
  • It does not seem like I can reduce the amount of files changed since the switch from contract factory to provider factory is required across the board in many tests and tasks

@janjakubnanista janjakubnanista marked this pull request as draft August 20, 2024 18:41
@janjakubnanista janjakubnanista marked this pull request as ready for review August 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant