🧹 Added unit tests for MyONFT721.sol example #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,152 @@ | |||
| // SPDX-License-Identifier: UNLICENSED | |||
There was a problem hiding this comment.
These tests are not run. You need to modify the "test" script in package.json to:
"test": "$npm_execpath run test:forge && $npm_execpath run test:hardhat",
| // DevTools imports | ||
| import { TestHelperOz5 } from "@layerzerolabs/test-devtools-evm-foundry/contracts/TestHelperOz5.sol"; | ||
|
|
||
| contract MyONFT721Test is TestHelperOz5 { |
There was a problem hiding this comment.
Are these new tests? Why wouldn't you just import the ones from:
| ONFT721Mock private aONFT721; | ||
| ONFT721Mock private bONFT721; | ||
|
|
||
| address private userA = address(0x1); |
There was a problem hiding this comment.
Use makeAddr("userA") and makeAddr("userB") instead. This will enhance the error logs by replacing the address with the canonical name.
ryandgoulding
requested changes
Oct 31, 2024
janjakubnanista
changed the title
|
Added test script line to package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.