Enable local bucket store #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Nov 13, 2023
ian-shim
reviewed
Nov 13, 2023
5 tasks
ian-shim
approved these changes
Nov 13, 2023
| @@ -68,10 +68,17 @@ var ( | |||
| } | |||
| BucketTableName = cli.StringFlag{ | |||
There was a problem hiding this comment.
If this is set, it may break rate limiter, right?
Should we comment it out for now to make sure that this isn't accidentally set?
teddyknox
pushed a commit
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Marcelo Mariano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds an option for disperser to use local bucket store, as well as application locking for ratelimiting.
Checks