Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Encoding ]Request with pagination #157

Merged
merged 30 commits into from
Jan 12, 2024
Merged

[Encoding ]Request with pagination #157

merged 30 commits into from
Jan 12, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Jan 5, 2024 •
edited
Loading

Why are these changes needed?

Consume BlobStore Pagination API in EncodingStreamer
Implement changes to extend encoding streamer to use pagination

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

ian-shim
ian-shim reviewed Jan 5, 2024
View reviewed changes
disperser/disperser.go Outdated Show resolved Hide resolved
ian-shim
ian-shim reviewed Jan 5, 2024
View reviewed changes
disperser/batcher/encoding_streamer.go Outdated Show resolved Hide resolved
disperser/batcher/encoding_streamer.go Outdated Show resolved Hide resolved
@siddimore siddimore marked this pull request as ready for review January 5, 2024 19:43
Siddharth More added 16 commits January 5, 2024 13:15
ian-shim
ian-shim reviewed Jan 10, 2024
View reviewed changes
disperser/common/blobstore/blob_metadata_store.go Outdated Show resolved Hide resolved
common/aws/dynamodb/client.go Outdated Show resolved Hide resolved
disperser/cmd/batcher/flags/flags.go Outdated Show resolved Hide resolved
disperser/common/blobstore/blob_metadata_store.go Outdated Show resolved Hide resolved
disperser/disperser.go Outdated Show resolved Hide resolved
disperser/common/inmem/store.go Show resolved Hide resolved
inabox/deploy/config.go Outdated Show resolved Hide resolved
disperser/common/blobstore/blob_metadata_store.go Outdated Show resolved Hide resolved
ian-shim
ian-shim approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

disperser/cmd/batcher/flags/flags.go Outdated Show resolved Hide resolved
disperser/common/blobstore/blob_metadata_store.go Outdated Show resolved Hide resolved
@siddimore siddimore merged commit 1ffc11e into Layr-Labs:master Jan 12, 2024
4 checks passed
@ian-shim ian-shim mentioned this pull request Jan 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddimore @ian-shim