[encodingstreamer] Consider blobs pending confirmation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
enc-streamer-status
branch
from
ca7368a
to
2d3bb04
Compare
mooselumph
reviewed
Jan 10, 2024
Comment on lines
+154
to
159
| } else if encodedResult.ReferenceBlockNumber < blockNumber { | ||
| // this is safe: https://go.dev/doc/effective_go#for | ||
| delete(e.encoded, k) | ||
| staleCount++ | ||
| e.encodedResultSize -= getChunksSize(encodedResult) | ||
| } else { |
There was a problem hiding this comment.
Curious about whether this case could actually happen?
Possibilities:
- I guess since confirmation is happening in another thread, and we don't have locks (e.g. batcher.go, L288), it could be possible that the blob is marked as confirmed in the confirmation thread but not yet removed from the store. But not sure we need to handle that case here.
- A blob was encoded but somehow the confirmation transaction never took place. I guess this could probaby happen somehow.
There was a problem hiding this comment.
I don't think encodedResult.ReferenceBlockNumber > blockNumber would be ever true, and it would be a bug in that case?
- Although there is no lock in batcher.go:288, it calls
DeleteEncodingResultwhich would lock the encoded blob store. In that case though,encodedResult.Statuswould bePendingConfirmation, right? - Depends on how the confirmation transaction ended up not taking place. If it failed somehow,
handleFailurewould remove the blob from encoded blob store so that it can be re-encoded & retried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Now that onchain confirmation is handled asynchronously, few things need to change in encoding streamer.
At encoding time, it should not encode blobs that are already pending confirmation.
At batch creation time, it shouldn't delete blobs pending confirmation even if they're stale.
At batcher, 1) blobs should be marked as pending confirmation once it's dispersed to DA nodes, and 2) removed from encoded blob store when batching finishes even when they fail
Checks