[node] Add more info on error logs #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
node-err-logging
branch
from
b5ef5bc
to
5c9d218
Compare
ian-shim
commented
Jan 18, 2024
| @@ -10,7 +10,6 @@ import ( | |||
|
|
|||
| var ( | |||
| ErrChunkLengthMismatch = errors.New("chunk length mismatch") | |||
| ErrInvalidHeader = errors.New("invalid header") | |||
| @@ -9,7 +9,6 @@ import ( | |||
|
|
|||
| var ( | |||
| ErrChunkLengthMismatch = errors.New("chunk length mismatch") | |||
| ErrInvalidHeader = errors.New("invalid header") | |||
| @@ -28,7 +29,11 @@ var ( | |||
|
|
|||
| // Assignment | |||
|
|
|||
| type OperatorID = [32]byte | |||
There was a problem hiding this comment.
type aliases are convenient, but I think strict types are safer in general (and allow receiver functions)
jianoaix
approved these changes
Jan 19, 2024
| @@ -114,7 +114,7 @@ func (f *operatorSocketsFilterer) WatchOperatorSocketUpdate(ctx context.Context, | |||
| } | |||
|
|
|||
| sink := make(chan *blsregcoord.ContractBLSRegistryCoordinatorWithIndicesOperatorSocketUpdate) | |||
| operatorID := []core.OperatorID{operatorId} | |||
| operatorID := [][32]byte{operatorId} | |||
There was a problem hiding this comment.
Is this intended given the goal of this pr?
There was a problem hiding this comment.
yeah this is a consequence of making core.OperatorID an explicit type - contract bindings aren't aware of core.OperatorID, so needs to be converted to a primitive type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
core.OperatorIDand explicit type instead of an alias, and added a helper method to convert to hex stringChecks