Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node api work and add node version #197

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Jan 19, 2024

Why are these changes needed?

localhost is loopback url so we should not provide it as address to http server when we want to access from docker container. We can just provide the :port and it will be accessible

  • Also added DA node version

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@shrimalmadhur shrimalmadhur marked this pull request as ready for review January 19, 2024 23:37
@shrimalmadhur shrimalmadhur changed the title debugging node api Make node api work and add node version Jan 19, 2024
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
how has this been tested?

@shrimalmadhur
Copy link
Contributor Author

shrimalmadhur commented Jan 20, 2024

lgtm how has this been tested?

I used my preprod node and deployed this version (before changing semvar)

ubuntu@ip-172-31-21-228:~/eigenda-operator-setup$ curl http://localhost:9091/eigen/node
{"node_name":"da-node","node_version":"0.0.1","spec_version":"v0.0.1"}

We need to change the operator setup repo so that the nodeapi port is open to internet

@shrimalmadhur shrimalmadhur merged commit 3a0ae9a into master Jan 20, 2024
5 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/debug-nodeapi branch January 20, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants