Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify installation instructions for AWS CLI in README #284

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

DudessaPr
Copy link

@DudessaPr DudessaPr commented Feb 26, 2024

Why are these changes needed?

This PR should solve the issue: #45

I had a similar error running "make deploy-all" in Inabox directory
On the master branch I got the error which was caused by commented lines in deploy/utils.go

// TODO: When these are uncommented, the deployer sometimes fails to start anvil
// cmd.Stdout = &out
// cmd.Stderr = &stderr

Could not connect to docker: reached retry deadline: exit status 127: 
2024/02/25 12:27:11 reached retry deadline: exit status 127: 
exit status 1
make: *** [deploy-all] Error 1

Then on opstack-poc branch had the error something like "aws command not found". That's why I think it is important to mention the AWS CLI installation in the README file.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@teddyknox teddyknox merged commit 98eafc5 into Layr-Labs:opstack-poc Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants