Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate churner request #30

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Validate churner request #30

merged 2 commits into from
Nov 14, 2023

Conversation

mooselumph
Copy link
Contributor

Why are these changes needed?

Adds further request validation to churner.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

gpsanant
gpsanant approved these changes Nov 14, 2023
View reviewed changes
Copy link

@gpsanant gpsanant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mooselumph mooselumph merged commit 8870629 into Layr-Labs:master Nov 14, 2023
4 checks passed
@mooselumph mooselumph deleted the churner-validation branch November 14, 2023 23:37
jianoaix pushed a commit that referenced this pull request Nov 14, 2023
@mooselumph @jianoaix
Validate churner request (#30)
f08ac71
teddyknox pushed a commit that referenced this pull request Nov 16, 2023
@gpsanant
fix build errors (#30)
6822a36
mooselumph added a commit that referenced this pull request Nov 16, 2023
@mooselumph
Client IP detection (#30) (#34)
a5667d2
jianoaix pushed a commit that referenced this pull request Nov 16, 2023
@mooselumph @jianoaix
Client IP detection (#30) (#34)
cd6a7b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsanant gpsanant gpsanant approved these changes

@jianoaix jianoaix jianoaix approved these changes

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mooselumph @gpsanant @jianoaix @ian-shim