Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing context when submitting transaction #33

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Use existing context when submitting transaction #33

merged 1 commit into from
Nov 15, 2023

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Nov 15, 2023 •
edited
Loading

Why are these changes needed?

Making EnsureTransactionEvaled use context passed in from the caller, so that it can be timed out

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review November 15, 2023 17:00
@ian-shim ian-shim merged commit 04a624f into Layr-Labs:master Nov 15, 2023
3 of 4 checks passed
jianoaix pushed a commit that referenced this pull request Nov 15, 2023
@ian-shim @jianoaix
Use existing context when submitting transaction (#33)
f4fdae8
teddyknox pushed a commit that referenced this pull request Nov 16, 2023
@mooselumph
Add blob queue (#33)
8664a9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@jianoaix jianoaix jianoaix approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @dmanc @jianoaix