Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort blobs feed by batchID/BlobIndex and return Cost in Gas instead of WEI #35

Conversation

wmb-software-consulting
Copy link
Contributor

@wmb-software-consulting wmb-software-consulting commented Nov 15, 2023

Why are these changes needed?

  • Blob feed ordering by <BatchID, BlobIndex>
  • Gas cost on blob explorer (gas/byte, not wei/byte)

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpsanant @QuinnLee please review the two changes in this PR: whether the ordering makes sense; whether the gas cost makes sense.

Signed-off-by: Wellington Barbosa <[email protected]>
@wmb-software-consulting wmb-software-consulting merged commit c2e40cb into Layr-Labs:master Nov 16, 2023
3 of 4 checks passed
@wmb-software-consulting wmb-software-consulting deleted the feat/sort-dataapi-feed-blobs branch November 16, 2023 17:07
jianoaix pushed a commit that referenced this pull request Nov 16, 2023
…f WEI (#35)

Signed-off-by: Wellington Barbosa <[email protected]>
Co-authored-by: Wellington Barbosa <[email protected]>
hopeyen pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants