Compute the stake by quorums #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
requested review from
gpsanant,
bxue-l2 and
wmb-software-consulting
jianoaix
commented
Nov 16, 2023
| @@ -17,19 +17,21 @@ const ( | |||
| ) | |||
|
|
|||
| func (s *server) getMetric(ctx context.Context, startTime int64, endTime int64, limit int) (*Metric, error) { | |||
| operators, err := s.subgraphClient.QueryOperatorsWithLimit(ctx, limit) | |||
There was a problem hiding this comment.
This is not only inefficient, but also incorrect: if we have more than 10 operators (the default limit), we will not get the total stake.
teddyknox
pushed a commit
that referenced
this pull request
Nov 16, 2023
wmb-software-consulting
approved these changes
Nov 16, 2023
jianoaix
commented
Nov 16, 2023
| blockNumber, err := s.transactor.GetCurrentBlockNumber(ctx) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get current block number: %w", err) | ||
| } | ||
| totalStake, err := s.calculateTotalStake(operators, blockNumber) | ||
| operatorState, err := s.chainState.GetOperatorState(ctx, uint(blockNumber), []core.QuorumID{core.QuorumID(0)}) |
There was a problem hiding this comment.
@gpsanant we are counting on this to get the stakes onchain, let me know if it's not reliable, we'd otherwise merge this PR
gpsanant
approved these changes
Nov 17, 2023
hopeyen
pushed a commit
that referenced
this pull request
Sep 18, 2024
…eters [INT-114] chore: add missing help parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a simpler and more efficient way to compute stake:
It issues just one RPC to just eth node.
Checks