-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixify #86
base: master
Are you sure you want to change the base?
nixify #86
Conversation
@kayvank Thanks for this PR. overall, it does lgtm. I will take a deeper look and run through the commands tomorrow am |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for sending this in! i've left a few comments if you'd be able to take a look
flake.nix
Outdated
eza | ||
rust-analyzer-unwrapped | ||
|
||
nodejs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be pinned to 20.12.12? otherwise it's changing the node version for the project and modifying the package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be pinned to 20.12.12? otherwise it's changing the node version for the project and modifying the package-lock.json
@eigen-vi Would you be OK with pinning it to node_20 which is Version: 20.15.1, see nix-package-search
This node version still changes some package versions in the package-lock.json, but not as drastically as before.
To pin to that specific version, I'll have to use the exact URL for each platform binary of the node 20.12.12. Here is an example
flake.nix
Outdated
export ETH_RPC_URL='127.0.0.1:8545' | ||
export ETHERSCAN_API_KEY='fake-key' | ||
export HOLESKY_PRIVATE_KEY='fake-key' | ||
export PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could these be removed? we're likely going to have a more sophisticated setup for env vars later, and this will cause surprises
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that a better solution is required here @eigen-vi and I would like to work on that next.
The rust code has a few dependencies on environment variables.
I can remove them. However, the rust code is dependent on these environment variables.
593ce13
to
cc98179
Compare
Add nix related artifacts to make project build in nixos
to verify:
this is for issue #74