overall 3.0.3 review #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^the only critical thing here is already included within the PR#32, so closing as there's no significance to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly for my own educational purposes to become more familiar with the integration; I looked at all changes between
v3.0.3andeigenda-v3.0.3else iffor methodName consistency ; in the case where bothuse4844anduseEigenDA,use4844encoding will be used but the method name would currently be assigned to for EigenDA.switchforencodeAddBatchpath (thinking it is more efficient but not a big deal in this scenario) , factored outencodeEigenDABatchto its own functioneigendapackage to eigenda repo and give it some name likeEigenDARollupUtil?