-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to minimum iOS version 10.0 #568
base: master
Are you sure you want to change the base?
Conversation
@nzagorchev how can I push this forward? I think it will clean up the code base significantly. |
Thank you @via-guy for this contribution. Is this blocking your integration? Are you integrating with mparticle and what is the impact? |
@nzagorchev no, it's not blocking me anymore. I thought that it was, originally, but I managed to resolve the issue. Still, seems a bit unnecessary to continue backwards-supporting so far. The original issue itself was in @objc @available(iOS 10.0, *)
public lazy var pushNotificationPresentationOption:UNNotificationPresentationOptions = [] Some compiler didn't like the combination of |
@nzagorchev the only thing we're blocked with is upgrading to a newer version of Leanplum. Using the mParticle integration we're stuck on 4.1. We need this fix implemented and released so that mparticle-integrations/mparticle-apple-integration-leanplum#20 can be merged. |
@nzagorchev seems it's not blocking us anymore. I think it'll still be nice to upgrade anyway, just to clean the code. Supporting iOS 9 is pretty excessive at this point. |
@nzagorchev any update? |
Notes on PR descriptions
Background
Sorry, I can't open tickets or anything, I just needed to create this change for our project and was hoping we could update directly at the source.
I had a compilation issue but it was with an older version of Leanplum-iOS-SDK and it looked like a good idea to upgrade the project to min SDK iOS 10. Seems that wasn't really necessary, but if you'd like to do it then here's how. 🤷
Implementation
API_AVAILABLE(ios(10.0))
Testing steps
N/A
Is this change backwards-compatible?
No, hence incrementing the major version in
sdk-version.txt
.