Restore executor configuration for zio-grpc #443
Conversation
| * availableProcessors(). Only the workStealing and fixed executors will use | ||
| * this value. | ||
| */ | ||
| val threads = System.getenv("JVM_EXECUTOR_THREADS") |
There was a problem hiding this comment.
In general, should this be rather GRPC_SERVER_CPUS? This is the variable we pass to servers so that they know how many will be available upfront. Or, will the JVM_EXECUTOR_THREADS correctly do that under the hood? Unless there is some JVM magic happening, the service will assume max CPUs on the host (e.g., 32), use a proper GC for that but then it'll get clamped at, e.g., 1. This may also be the case for other JVM-based implementations here.
There was a problem hiding this comment.
Yeah I don't think there's any magic, so it will use Runtime.getRuntime.availableProcessors. I just copied the way it was done in the fs2 one, it seems to be used that way in 4 different tests: https://github.com/search?q=repo%3ALesnyRumcajs%2Fgrpc_bench%20JVM_EXECUTOR_THREADS&type=code
Shall I change them all to use GRPC_SERVER_CPUS instead?
There was a problem hiding this comment.
I just changed it.
Summary of changes
Changes introduced in this pull request: