libvncclient: improve compatibility with GnuTLS 3.8 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GnuTLS 3.8, TTLS-SRP is disabled by default at compile time [1]. As a result, connecting to a server via TLS fails with: > Warning: Failed to set TLS priority: The request is invalid. (+SRP). > TLS handshake failed: No or insufficient priorities were set. On the other hand, TLS-SRP is apparently unused in libvncclient. It seems TLS-SRP requires providing serveral parameters, including a username and a password, via specific GnuTLS API [2], which I didn't find in the codebase. [1] https://gitlab.com/gnutls/gnutls/-/merge_requests/1681 [2] https://www.gnutls.org/manual/html_node/Authentication-using-SRP.html
|
Thanks! |
|
Whoa, that's blazingly fast! Thank you very much. |
|
That was just a coincidence with me being online and the change being very small ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GnuTLS 3.8, TTLS-SRP is disabled by default at compile time [1]. As a result, connecting to a server via TLS fails with:
On the other hand, TLS-SRP is apparently unused in libvncclient. It seems TLS-SRP requires providing serveral parameters, including a username and a password, via specific GnuTLS API [2], which I didn't find in the codebase.
[1] https://gitlab.com/gnutls/gnutls/-/merge_requests/1681
[2] https://www.gnutls.org/manual/html_node/Authentication-using-SRP.html