Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gha caching for dev images #24

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Conversation

pratikbin
Copy link
Contributor

  • I think we should skip caching for production image building
  • and comment below if you want to build this for more multiple platforms, I can try some things

- I think we should skip caching in production image building because we want fresh image
@derneuere
Copy link
Member

Thanks for the pull request. Didn't knew that this feature exists 😄 I agree production image should be build from scratch 👍
I can't really test different architectures and we have alot of difficult dependencies in the backend that only crash on startup and not on build.

We have this base image "librephotos-dependencies" for the backend. This image is large (8GB), because we install all of the build dependencies. If you want to work more on this, than that would be awesome #15

https://github.com/LibrePhotos/librephotos-docker/blob/main/backend/dependencies/Dockerfile

I think that the dependency image would also need this change, but you can address this in a separate commit 👍

@derneuere derneuere merged commit b05d68a into LibrePhotos:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants