Skip to content

Commit

Permalink
Remove links to join slack community (#15)
Browse files Browse the repository at this point in the history
### Changelog
Removing links for slack in the User menu.

### Description

Since we are no longer pointing to the slack community, we need to adapt our user menu to remove it.
  • Loading branch information
laisspportugal authored Apr 15, 2024
1 parent a606be7 commit 97698d5
Show file tree
Hide file tree
Showing 14 changed files with 5 additions and 116 deletions.
3 changes: 0 additions & 3 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,3 @@ contact_links:
- name: "📚 Stack Exchange"
url: https://robotics.stackexchange.com/questions/ask
about: Get help from the robotics community
- name: "💬 Live chat"
url: https://foxglove.dev/slack
about: Join the discussion in our Slack community
4 changes: 0 additions & 4 deletions packages/studio-base/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ import fuzzyFilter from "@foxglove/studio-base/util/fuzzyFilter";
```

For a full list of the package's exports, reference its [`index.ts` file](https://github.com/foxglove/studio/blob/main/packages/studio-base/src/index.ts).

## Stay in touch

Join us in [Slack](https://foxglove.dev/slack) to ask questions, share feedback, and stay up to date on what our team is working on.
14 changes: 1 addition & 13 deletions packages/studio-base/src/components/AppBar/AppMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,6 @@ export function AppMenu(props: AppMenuProps): JSX.Element {
handleNestedMenuClose();
}, [handleNestedMenuClose]);

const onSlackClick = useCallback(() => {
window.open("https://foxglove.dev/slack", "_blank");
handleNestedMenuClose();
}, [handleNestedMenuClose]);

const onDemoClick = useCallback(() => {
dialogActions.dataSource.open("demo");
handleNestedMenuClose();
Expand All @@ -204,17 +199,10 @@ export function AppMenu(props: AppMenuProps): JSX.Element {
{ type: "item", key: "about", label: t("about"), onClick: onAboutClick },
{ type: "divider" },
{ type: "item", key: "docs", label: t("viewOurDocs"), onClick: onDocsClick, external: true },
{
type: "item",
key: "join-slack",
label: t("joinOurSlack"),
onClick: onSlackClick,
external: true,
},
{ type: "divider" },
{ type: "item", key: "demo", label: t("exploreSampleData"), onClick: onDemoClick },
],
[onAboutClick, onDemoClick, onDocsClick, onSlackClick, t],
[onAboutClick, onDemoClick, onDocsClick, t],
);

return (
Expand Down
29 changes: 1 addition & 28 deletions packages/studio-base/src/components/AppBar/HelpMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@
// License, v2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/

import { Cloud24Regular, SlideLayout24Regular } from "@fluentui/react-icons";
import {
ChatBubblesQuestion24Regular,
Cloud24Regular,
SlideLayout24Regular,
} from "@fluentui/react-icons";
import {
Divider,
ListItemText,
ListSubheader,
Menu,
Expand Down Expand Up @@ -127,28 +122,6 @@ export function HelpMenu(props: HelpMenuProps): JSX.Element {
secondaryTypographyProps={{ className: classes.menuText }}
/>
</MenuItem>
<Divider />
<ListSubheader className={classes.subheader}>Community</ListSubheader>
<MenuItem
href="https://foxglove.dev/slack"
className={classes.menuItem}
component="a"
target="_blank"
onClick={() => {
void analytics.logEvent(AppEvent.HELP_MENU_CLICK_CTA, {
user: currentUserType,
cta: "join-slack",
});
handleClose();
}}
>
<ChatBubblesQuestion24Regular className={classes.icon} />
<ListItemText
primary="Join us on Slack"
secondary="Give us feedback, ask questions, and collaborate with other users"
secondaryTypographyProps={{ className: classes.menuText }}
/>
</MenuItem>
</Menu>
);
}
5 changes: 0 additions & 5 deletions packages/studio-base/src/components/AppBar/SettingsMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ export function SettingsMenu({
window.open("https://docs.foxglove.dev/docs", "_blank");
}, []);

const onSlackClick = useCallback(() => {
window.open("https://foxglove.dev/slack", "_blank");
}, []);

return (
<>
<Menu
Expand Down Expand Up @@ -94,7 +90,6 @@ export function SettingsMenu({
</MenuItem>
<Divider variant="middle" />
<MenuItem onClick={onDocsClick}>{t("documentation")}</MenuItem>
<MenuItem onClick={onSlackClick}>{t("joinSlackCommunity")}</MenuItem>
</Menu>
</>
);
Expand Down
36 changes: 0 additions & 36 deletions packages/studio-base/src/components/DataSourceDialog/Start.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -207,42 +207,6 @@ function SidebarItems(props: {
freeUser: [demoItem],
teamOrEnterpriseUser: [
demoItem,
{
id: "join-community",
title: t("joinOurCommunity"),
text: t("joinOurCommunityDescription"),
actions: (
<>
<Button
href="https://foxglove.dev/slack"
target="_blank"
className={classes.button}
variant="outlined"
onClick={() => {
void analytics.logEvent(AppEvent.DIALOG_CLICK_CTA, {
user: currentUserType,
cta: "join-slack",
});
}}
>
{t("joinOurSlack")}
</Button>
<Button
href="https://github.com/foxglove/studio/issues/new/choose"
target="_blank"
className={classes.button}
onClick={() => {
void analytics.logEvent(AppEvent.DIALOG_CLICK_CTA, {
user: currentUserType,
cta: "go-to-github",
});
}}
>
{t("openAGitHubIssue")}
</Button>
</>
),
},
{
id: "need-help",
title: t("needHelp"),
Expand Down
3 changes: 1 addition & 2 deletions packages/studio-base/src/context/NativeAppMenuContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ export type NativeAppMenuEvent =
| "open-demo"
| "open-help-about"
| "open-help-docs"
| "open-help-general"
| "open-help-slack";
| "open-help-general";

type Handler = () => void;
type UnregisterFn = () => void;
Expand Down
2 changes: 0 additions & 2 deletions packages/studio-base/src/i18n/en/appBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export const appBar = {
hideLeftSidebar: "Hide left sidebar",
hideRightSidebar: "Hide right sidebar",
importLayoutFromFile: "Import layout from file…",
joinOurSlack: "Join our Slack",
joinSlackCommunity: "Join Slack community",
noDataSource: "No data source",
open: "Open…",
openConnection: "Open connection…",
Expand Down
4 changes: 0 additions & 4 deletions packages/studio-base/src/i18n/en/openDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export const openDialog = {
"Use a convenient web interface to tag, search, and retrieve data at lightning speed",
createAFreeAccount: "Create a free account",
exploreSampleData: "Explore sample data",
joinOurCommunity: "Join our community",
joinOurCommunityDescription:
"Join us on Slack or GitHub to get help, make feature requests, and report bugs.",
joinOurSlack: "Join our Slack",
learnMore: "Learn more",
needHelp: "Need help?",
needHelpDescription: "View our documentation, or check out the tutorials on the Foxglove blog.",
Expand Down
5 changes: 2 additions & 3 deletions packages/studio-desktop/src/common/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ export type ForwardedMenuEvent =
| "open-demo"
| "open-help-about"
| "open-help-docs"
| "open-help-general"
| "open-help-slack";
| "open-help-general";

export type ForwardedWindowEvent =
| "enter-full-screen"
Expand Down Expand Up @@ -113,4 +112,4 @@ interface Desktop {
updateLanguage(): void;
}

export type { NativeMenuBridge, Storage, StorageContent, Desktop, DesktopExtension };
export type { Desktop, DesktopExtension, NativeMenuBridge, Storage, StorageContent };
6 changes: 0 additions & 6 deletions packages/studio-desktop/src/main/StudioWindow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -368,12 +368,6 @@ function buildMenu(browserWindow: BrowserWindow): Menu {
sendNativeAppMenuEvent("open-help-docs", browserWindow);
},
},
{
label: t("appBar:joinOurSlack"),
click: () => {
sendNativeAppMenuEvent("open-help-slack", browserWindow);
},
},
{ type: "separator" },
{
label: t("appBar:exploreSampleData"),
Expand Down
4 changes: 0 additions & 4 deletions packages/studio/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,3 @@
This package contains type definitions for writing [Foxbox](https://foxglove.dev/) extensions.

See https://docs.foxglove.dev/docs/visualization/extensions/introduction

## Stay in touch

Join us in [Slack](https://foxglove.dev/slack) to ask questions, share feedback, and stay up to date on what our team is working on.
2 changes: 0 additions & 2 deletions packages/theme/src/i18n/en/appBar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ export const appBar = {
hideLeftSidebar: "Hide left sidebar",
hideRightSidebar: "Hide right sidebar",
importLayoutFromFile: "Import layout from file…",
joinOurSlack: "Join our Slack",
joinSlackCommunity: "Join Slack community",
noDataSource: "No data source",
open: "Open…",
openConnection: "Open connection…",
Expand Down
4 changes: 0 additions & 4 deletions packages/theme/src/i18n/en/openDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export const openDialog = {
"Use a convenient web interface to tag, search, and retrieve data at lightning speed",
createAFreeAccount: "Create a free account",
exploreSampleData: "Explore sample data",
joinOurCommunity: "Join our community",
joinOurCommunityDescription:
"Join us on Slack or GitHub to get help, make feature requests, and report bugs.",
joinOurSlack: "Join our Slack",
learnMore: "Learn more",
needHelp: "Need help?",
needHelpDescription: "View our documentation, or check out the tutorials on the Foxglove blog.",
Expand Down

0 comments on commit 97698d5

Please sign in to comment.