Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR comes from a spike where we were trying to understand and fix the memory estimation. When reading one of the articles that was used for creating the memory estimation we realized that the calculation was wrong.
The actual formula is:
16+5 * 8+ round_up_to_2^n( (number of properties +2)* 1.5) ) * 3 * 8
instead of
16+5 * 8+ round_up_to_2^n( (number of properties +2)* 1.5) ) * 3 * 4
It could cause misscalculation and non efficient memory estimation
Checklist
Resources