Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update on comlink dependencies and imports #218

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ctw-joao-luis
Copy link
Collaborator

User-Facing Changes
Replaced how comlink imports are made, now calling comlink from @lichtblick/comlink instead. Update comlink on devDependencies as well

Description

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests

Copy link

sonarcloud bot commented Oct 11, 2024

laisspportugal
laisspportugal previously approved these changes Oct 11, 2024
Copy link
Collaborator

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen some error but I'm not sure if its related to the PR itself
Please check if you have this very same error when running the web version with a mcap file
image

@laisspportugal laisspportugal dismissed their stale review October 11, 2024 16:48

I've seen some error and would like to check before merging it

Copy link
Collaborator

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end I wasn't able to reproduce this error. Looks good :)

@ctw-joao-luis ctw-joao-luis merged commit 61a74e8 into main Oct 14, 2024
10 checks passed
@ctw-joao-luis ctw-joao-luis deleted the fixing-comlink-dependency branch October 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants