Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept relative paths on initial arguments #221

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

aneuwald-ctw
Copy link
Collaborator

User-Facing Changes
Linux users will be able to open Lichtblick using CLI and relative paths.

Description
Transforms every path received to absolute path, in order to increase linux compatibility

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok

@aneuwald-ctw aneuwald-ctw added the bug Something isn't working label Oct 14, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Collaborator

@laisspportugal laisspportugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I'm not sure if there is a way to test it by unit test, but if it has it will be nice to have it.

@aneuwald-ctw
Copy link
Collaborator Author

Test the main functionality of electron can be very tricky. I would say to let this without unit test by now and implement when we refactor and implement more tests globally.

@aneuwald-ctw aneuwald-ctw merged commit 88f2382 into main Oct 15, 2024
10 checks passed
@aneuwald-ctw aneuwald-ctw deleted the fix/accept-relative-paths branch October 15, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants