-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newmetric: Negative predictive value #2433
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…com/Lightning-AI/torchmetrics into newmetric/negative_predictive_value
def compute(self) -> Tensor: | ||
"""Compute metric.""" | ||
tp, fp, tn, fn = self._final_state() | ||
return _specificity_reduce(tp, fp, tn, fn, average="binary", multidim_average=self.multidim_average) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this (and the following compute functions) return _negative_predictive_value_reduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_negative_predictive_value_reduce has been defined here, but isn't used on this line for some reason
d0a5568
to
9fc79ae
Compare
What does this PR do?
Fixes #2415
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2433.org.readthedocs.build/en/2433/