Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCMock: Fix ios 15 device crash #14

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

byohay
Copy link

@byohay byohay commented May 1, 2022

No description provided.

@byohay byohay changed the base branch from master to test-master May 1, 2022 09:12
@byohay byohay changed the title feature/fix ios 15 device crash OCMock: Fix ios 15 device crash May 1, 2022
@byohay byohay changed the base branch from test-master to master May 3, 2022 07:08
This fixes up a crash that was found in Chrome when running on an iOS 15 device.
It did not show up on the simulator.

https://chromium-review.googlesource.com/c/chromium/src/+/3011651

Calling `object_getClass` on something that isn't an object is at best undefined
behavior.
@byohay byohay force-pushed the feature/fix-ios-15-device-crash branch from 84fcb4d to 5c318da Compare May 3, 2022 11:02
@byohay
Copy link
Author

byohay commented May 3, 2022

@ashdnazg PTAL

Copy link

@ashdnazg ashdnazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byohay byohay merged commit 0f2f5a8 into master May 4, 2022
@byohay byohay deleted the feature/fix-ios-15-device-crash branch May 4, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants