Implement Theming and add basic Component lib #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 2, 2024
konsumlamm
reviewed
Jun 12, 2024
Comeza
force-pushed
the
themes
branch
2 times, most recently
from
11f6a67
to
9f68490
Compare
konsumlamm
reviewed
Jun 13, 2024
Comment on lines
-22
to
-30
| export function HomeButton() { | ||
| const navigate = useNavigate(); | ||
|
|
||
| return ( | ||
| <Button onClick={() => navigate("/")}> | ||
| <FaHome /> | ||
| </Button> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Why remove the home button?
There was a problem hiding this comment.
I am currently experimenting with the Navbar and couldn't find space for it (It also didn't fit the theme). I will put it back sometime later.
Comment on lines
-35
to
-48
| function ResetMapViewButton() { | ||
| const map = useMap(); | ||
| const { t } = useTranslation(); | ||
|
|
||
| return ( | ||
| <div className="leaflet-top leaflet-center"> | ||
| <div className="leaflet-control leaflet-bar"> | ||
| <Button onClick={() => map.setView(CENTER, DEFAULT_ZOOM)}> | ||
| {t("ResetMapView")} | ||
| </Button> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Why? I find it pretty useful.
Will add modify the navbar in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30, #32
Theming
Component lib (
lila)(Color picker)