Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding from Spectrum Archive to Storage Archive and adding copyright year #422

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

juliocelon
Copy link
Contributor

@juliocelon juliocelon commented Aug 22, 2023

Rebranding from Spectrum Archive to Storage Archive and adding copyright year

@juliocelon juliocelon self-assigned this Aug 22, 2023
@juliocelon juliocelon changed the title Rebranding from Spectrum Archive to Storage Archive and add copyright year Rebranding from Spectrum Archive to Storage Archive and adding copyright year Aug 22, 2023
Copy link

@perezle perezle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with these changes

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy right year change might not be correct. Need to change.

Licensed Materials - Property of IBM
(C) Copyright IBM Corp. 2014, 2015"
(C) Copyright IBM Corp. 2014, 2015, 2023"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall be

(C) Copyright IBM Corp. 2014, 2023

First number shall be the year which is initially created, second number is the year which is last modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Abe-San

I've updated the copyright years as needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing.

But I realized that we don't need to change this line at all. Because second number shows the year which is late modified.

I believe we didn't change this file from 2015 at all...

src/ltfs_copyright.h Outdated Show resolved Hide resolved
…tially created, second number is the year which is last modified.
@juliocelon juliocelon added the to v2.4-stable Merge to v2.4-stable (and master) label Aug 24, 2023
@piste-jp
Copy link
Member

@juliocelon ,

I realized it is little bit funny to change the year in src/libltfs/LTFS-MIB.txt.

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. it looks good.

@juliocelon juliocelon merged commit 2273268 into v2.4-stable Aug 31, 2023
17 checks passed
@piste-jp piste-jp deleted the rebrand-storage-archive-and-copyright branch May 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to v2.4-stable Merge to v2.4-stable (and master)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants