Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Add Cocoapods static_framework support #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Cocoapods static_framework support #176

wants to merge 1 commit into from

Conversation

soniccat
Copy link

I see Cocoapods RC (1.4.0.rc.1) supports swift static frameworks. Added that to avoid creating a dynamic library.
The latest Cocoapods RC can be installed using this command sudo gem install cocoapods --pre

@@ -6,7 +6,7 @@
// software distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

import ObjectiveC
import Foundation
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced because of using NSNumber here. Had compile errors without that.

@staguer
Copy link
Contributor

staguer commented Jan 18, 2018

Hi @soniccat ! Can you please link me to some documentation for this static_framework flag?

Also, is this something that should be determined by those entities that import LayoutKit rather than by LayoutKit itself?

@soniccat
Copy link
Author

soniccat commented Jan 19, 2018

@staguer hi, here it is http://blog.cocoapods.org/CocoaPods-1.4.0/ I see they have written it recently

can't say about dependencies, need to read the doc, it seems setting the flag should be enough, at least I've tested that it works

@nicksnyder
Copy link
Collaborator

Lgtm based on reading doc. Any downsides?

@chenxiao0228
Copy link

Enabling this will cause the binary to be linked statically.

If the pod consumer has multiple targets using LayoutKit, LayoutKit will be liked multiple times.

Agree with @staguer it might be more appropriate for the consumers to decide how it will be linked.

Cocoapods 1.5.0 is adding support for this use case, FYI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants