Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gelato web3 function deployment script for redstone oracles #208
base: LISK-1155-Set-up-RedStone-Push-Oracle-contracts
Are you sure you want to change the base?
Add Gelato web3 function deployment script for redstone oracles #208
Changes from 1 commit
7f1933b
e798fe1
4a2a363
3ebd303
65ffb61
7509138
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
rm -rf node_modules && rm -rf dist
still be present to be able to properly clean TS files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could keep
rm -rf node_modules
but there is nodist
. A folder.tmp
andyarn.lock
are also generated as part of the process, should we remove them as part ofclean
too ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should then remove
node_modules
and.tmp
folders. Not sure if yarn.lock needs to be removed. Isn't it usually also commited and part of the repository?