update chromatic workflow #2917
Conversation
README.md
Outdated
| You can use Storybook to visualize and test out the UI components used throughout the app. | ||
|
|
||
| - To view Storybook on your local environment, run `pnmp storybook` on the `packages/webapp` directory and navigate to http://localhost:6006 | ||
| - To view the deployed version of Storybook, which is updated automatically with the latest changes on the integratio branch, go to https://65316fc4f177c73a9181a843-yobioprfjv.chromatic.com |
There was a problem hiding this comment.
A little typo, the "n" in "integration" is missing.
There was a problem hiding this comment.
Oops, thank you! 🙂
@kathyavini for sure, we can go over it in tech daily! |
It wasn't my request, but I would have had the same 😁 I'm looking forward to learning how this works! |
.github/workflows/chromatic.yml
Outdated
| with: | ||
| fetch-depth: 0 | ||
| - uses: pnpm/[email protected] | ||
| - name: Setup pnpm | ||
| uses: pnpm/[email protected] | ||
| with: | ||
| version: 6.26.1 |
There was a problem hiding this comment.
This should probably be updated too else it may install dependencies different from local.
There was a problem hiding this comment.
Good catch, done 🙂
Lol I tagged you instead of @SayakaOno 😅 sorry! |
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Sorry I did not notice this before but you have two action triggers here (workflow_dispatch and push) just thought I should ask if this is intentional. Normally we only have one or the other
Description
Updated Chromatic workflow to deploy Storybook based on the latest Storybook docs.
Jira link:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Set the workflow trigger to run on the pull request temporarily, checked that the action passed correctly, then switched the trigger back so it only runs when we merge a PR to integration.
Checklist: