-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] LF-4383 Animal details form container handle edit of animal details #3500
Draft
kathyavini
wants to merge
24
commits into
integration
Choose a base branch
from
LF-4383-animal-details-form-container-handle-edit-of-animal-details
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] LF-4383 Animal details form container handle edit of animal details #3500
kathyavini
wants to merge
24
commits into
integration
from
LF-4383-animal-details-form-container-handle-edit-of-animal-details
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure but perhaps the ts conversion of the Form Component explains the suddenly appearing ts errors?
…-handle-edit-of-animal-details
kathyavini
requested review from
antsgar and
SayakaOno
and removed request for
a team
October 15, 2024 22:04
Undefined property will occur in Storybook stories
…nimal vs batch logic; move date constructing function to utils.ts file
…ls Card Warning was 'Failed prop type: Invalid prop placeholder of type boolean supplied to ForwardRef(TextareaAutosize2), expected string'
…-handle-edit-of-animal-details
kathyavini
force-pushed
the
LF-4383-animal-details-form-container-handle-edit-of-animal-details
branch
from
October 22, 2024 19:18
df1ae90
to
3150a6f
Compare
Not my preferred method or UX because of the flash of old values, but moving the key created TypeError: Cannot destructure property 'FormContent' of 'steps[activeStepIndex]' as it is undefined
…elds WIP. Only completed for animal. Also nulling is okay but I don't think the dirtied fields is a great way to go; I will bring to daily discussion
Note that unregistering with shouldUnregister will not add it to dirtyFields. For this field, not sending a value actually is enough to null in the database; I think additional controller logic is probably in place.
…r nulling cleared fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Jira link: https://lite-farm.atlassian.net/browse/LF-4383
Type of change
How Has This Been Tested?
Checklist: