Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil email for team_user #1706

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: nil email for team_user #1706

merged 4 commits into from
Dec 12, 2023

Conversation

chasers
Copy link
Contributor

@chasers chasers commented Sep 25, 2023

Getting lots of errors for:

no function clause matching in Logflare.AccountEmail.schema_updated/4 (logflare 1.4.5) lib/logflare/account_email.ex:113: Logflare.AccountEmail.schema_updated(nil, %Logflare.Source{__meta_

@chasers chasers marked this pull request as ready for review September 25, 2023 14:03
@chasers chasers changed the title fix: log when we have a nil email for a user fix: nil email for team_user Sep 25, 2023
@hauleth
Copy link
Contributor

hauleth commented Nov 8, 2023

Are we going to merge it or close as stale?

@hauleth hauleth force-pushed the fix/nil-email-schema-alert branch 2 times, most recently from 4f62f0d to ca7b589 Compare November 20, 2023 10:43
@Ziinc
Copy link
Contributor

Ziinc commented Dec 12, 2023

fixed the failing test, merging in once tests pass.

@Ziinc Ziinc merged commit 1f58788 into main Dec 12, 2023
2 checks passed
@Ziinc Ziinc deleted the fix/nil-email-schema-alert branch December 12, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziinc Ziinc Ziinc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasers @hauleth @Ziinc