Fix/secrets management scripts, ssl for otp26 #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hauleth would be good if you could have a look at the makefile stuff in case i missed something. |
Ziinc
changed the title
filipecabaco
approved these changes
Oct 13, 2023
hauleth
reviewed
Oct 13, 2023
Comment on lines
+223
to
+224
| System.get_env("DB_SSL") == "true" && File.exists?("db-server-ca.pem") && | ||
| File.exists?("db-client-ca.pem") && File.exists?("db-client-key.pem") |
There was a problem hiding this comment.
I am pretty sure that checking for paths like that can fail in release, as these files may not be where we want them to be. Maybe instead use DB_SSL as a path to where these files will be stored? That should make the configuration more flexible.
There was a problem hiding this comment.
agreed. yes we can update the certfile loading method for both db and grpc, can do this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the secrets encryption/decryption scripts.
Behaviour is decoupled when running
make encrypt.*andmake decrypt.*to prevent overriding of local unencrypted/uncommited changes.This PR also adds in ecto ssl_opts, and also adds in the required staging/prod db ssl certs to get ssl properly supported on otp26.
I have also updated naming of the google cloud keys, so that it is easier to work with the makefile patterns.