Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/secrets management scripts, ssl for otp26 #1756

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Oct 13, 2023

This PR fixes the secrets encryption/decryption scripts.

Behaviour is decoupled when running make encrypt.* and make decrypt.* to prevent overriding of local unencrypted/uncommited changes.

This PR also adds in ecto ssl_opts, and also adds in the required staging/prod db ssl certs to get ssl properly supported on otp26.

I have also updated naming of the google cloud keys, so that it is easier to work with the makefile patterns.

@Ziinc
Copy link
Contributor Author

Ziinc commented Oct 13, 2023

@hauleth would be good if you could have a look at the makefile stuff in case i missed something.

@Ziinc Ziinc changed the title Fix/secrets management scripts Fix/secrets management scripts, ssl for otp26 Oct 13, 2023
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Comment on lines +223 to +224
System.get_env("DB_SSL") == "true" && File.exists?("db-server-ca.pem") &&
File.exists?("db-client-ca.pem") && File.exists?("db-client-key.pem")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that checking for paths like that can fail in release, as these files may not be where we want them to be. Maybe instead use DB_SSL as a path to where these files will be stored? That should make the configuration more flexible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. yes we can update the certfile loading method for both db and grpc, can do this in a separate PR.

@Ziinc Ziinc merged commit cc86691 into main Oct 16, 2023
3 checks passed
@Ziinc Ziinc deleted the fix/secrets-management-scripts branch October 16, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants