fix: :buffer_counter_not_found bug #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasers
reviewed
Nov 14, 2023
chasers
reviewed
Nov 14, 2023
chasers
approved these changes
Nov 14, 2023
|
@Ziinc approving for async's sake. Only thing I'm kind of concerned about is the exit trapping. |
|
adjusted based on review changes. will get this deployed today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error gets thrown when the RLS does not start up fast enough for incoming requests. This change ensures that the startup of the critical genservers are performed in the init and is blocking.