Merge pull request #414 from Lombiq/issue/OSOE-909

OSOE-909: Updating Atata.WebDriverSetup and re-enabling Edge tests
Lombiq · Oct 9, 2024 · 6ea2be9 · 6ea2be9
2 parents 014340e + c0e8d9d
commit 6ea2be9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs b/Lombiq.Tests.UI.Samples/Tests/BasicVisualVerificationTests.cs
@@ -55,7 +55,7 @@ public Task VerifyBlogImage() =>
     // is the different rendering of text on each platform, but it can occur between different Linux distributions too.
     // Here: https://pandasauce.org/post/linux-fonts/ you can find a good summary about this from 2019, but still valid
     // in 2022.
-    [Theory, Chrome, Edge(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")]
+    [Theory, Chrome, Edge]
     public Task VerifyNavbar(Browser browser) =>
         ExecuteTestAfterSetupAsync(
             context =>

diff --git a/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs b/Lombiq.Tests.UI.Samples/Tests/MultiBrowserTests.cs
@@ -23,17 +23,15 @@ public MultiBrowserTests(ITestOutputHelper testOutputHelper)
 
     // First, let's see a test using Edge. While the default browser is Chrome if you don't set anything, all
     // ExecuteTest* methods can also accept a browser, if you want to use a different one.
-#pragma warning disable xUnit1004
-    [Fact(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")]
-#pragma warning restore xUnit1004
+    [Fact]
     public Task AnonymousHomePageShouldExistWithEdge() =>
         ExecuteTestAfterSetupAsync(NavbarIsCorrect, Browser.Edge);
 
     // This test is now marked not with the [Fact] attribute but [Theory]. With it, you can create so-called data-driven
     // tests. [Chrome] and [Edge] are input parameters of the test, and thus in effect, you have now two tests:
     // AnonymousHomePageShouldExistMultiBrowser once with Chrome, and once with Edge. See here for more info:
     // https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/.
-    [Theory, Chrome, Edge(Skip = "Until not resolved: https://github.com/atata-framework/atata-webdriversetup/issues/16")]
+    [Theory, Chrome, Edge]
     public Task AnonymousHomePageShouldExistMultiBrowser(Browser browser) =>
         ExecuteTestAfterSetupAsync(NavbarIsCorrect, browser);
 

diff --git a/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj b/Lombiq.Tests.UI/Lombiq.Tests.UI.csproj
@@ -66,7 +66,7 @@
     <PackageReference Include="Atata.Bootstrap" Version="3.0.0" />
     <PackageReference Include="Atata.HtmlValidation" Version="3.1.0" />
     <PackageReference Include="Atata.WebDriverExtras" Version="3.0.0" />
-    <PackageReference Include="Atata.WebDriverSetup" Version="2.13.0" />
+    <PackageReference Include="Atata.WebDriverSetup" Version="2.14.0" />
     <PackageReference Include="Azure.Storage.Blobs" Version="12.19.1" />
     <PackageReference Include="Ben.Demystifier" Version="0.4.1" />
     <PackageReference Include="Codeuctivity.ImageSharpCompare" Version="4.0.258" />