Fix/thicknesses_

[AngRodrigues]

Summary of major changes:

• Thickness outputs from all thickness calculators are now merged
• LPF version pinned to 1.4
• Added folder with datasets in map2loop/_datasets/geodata_files/hamersley. The idea behind this is to have a data loading function, e.g., at the moment load_hamersley_geology() returns a gdf with the geology; structure and dtm are available, and others will be added later on. This is quite useful for tests, but should also be useful for when we implement [Feature Request] - create map2loop project from geopandas array not file paths #74. The only thing about this is the location, which implies a long import: from map2loop._datasets.geodata_files.hamersley import load_hamersley_geology. Happy to change the file location - does anyone has a suggestion?
• Minimum fault length is now a parameter of the config file, and it actually removes the faults with length under defined value.
• Removed the project.set_minimum_fault_length method to avoid users setting the parameter twice.
• added all_basal_contacts object which are abnormal+basal contacts , and basal_contacts holds only the basal. Reconstruction of sampled_basal_contacts is based on basal_contacts
• changed the thickness_calculator_alpha to be coherent with the logic of the other thickness calculators
• added tests for some of the functions in mapdata.py
• added tests for thickness_compute in project.py
• rewrote tests for all thickness calculators independently (now without having to run the project)

summary of other minor modifications:

• tmpfile is now used to create the localGdalfile
• changed to f"" strings where possible
• change from os.path.join to pathlib.Path where possible
• added geopandas to csv converter in mapdata (it was on a #TODO)
• added check and error message to make sure that all units in user_defined_stratigraphic_column are in the geology file (otherwise project creation fails; at least now user has a warning).
• renamed distance to stratigraphic_distance in basal_contacts creation
• removed set_ and get_thickness_calculator
• rectified minor typos in the thickness calculators
• added a Linalgerror catch/pass for the InterpolatedStructure

Fixes #86
Fixes #110
Fixes #111
Fixes #12

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Test improvement

How Has This Been Tested?

The branch is fix/thicknesses_AR_2.

Checklist:

• This branch is up-to-date with master
• All gh-action checks are passing
• I have performed a self-review of my own code
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works
• My tests run with pytest from the map2loop folder
• New and existing tests pass locally with my changes

[lachlangrose]

should this be a parameter that can be initialised?

[rabii-chaarani]

in case it's not user-defined, I think it would be better to automatically calculate the minimum fault length given the scale of the map

[lachlangrose]

Could you not just put the thickness_combined_results directly inside the stratigraphicUnits inside the for loop. This means you aren't hard coding the number of thickness calculators

[lachlangrose]

Is there a way to make this generic so that the user can specify thickness calculators to keep map2loop being modular?

[lachlangrose]

I haven't reviewed or tested the code but I have made some suggestions within the code.

My main comment for this PR is that the changes to the thickness calculators have not been implemented in the modular framework of map2loop. Instead of setting the list of thickness calculators within the method calling the thickness calculators, the list of thickness calculators should be managed by the project class. The default list can be hard coded using the current three, but the user should be able to call set_thickness_calculators and provide a custom list of thickness calculators.

This would mean, if the thicknesss calculators have any parameters e.g. the threshold angle for the structure point, or the interpolator type for the interpolated structure these could be set by the user and the thickness calculator objects can be set.