This repository has been archived by the owner on Mar 18, 2019. It is now read-only.
WIP: Minor Code changes that optimise gas use #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2018 22:48
Change Log: Assemblified subring Check ~= 100 gas reduction Removed all add( x , 0) instances from assembly operations as they are redundant/wasting gas Replaced clear multiplication instances with answer ie instances with 32*5 with 160 ~= 250 gas reduction Refactored calculation of memory required by lists, using assembly and a new calculate function. this stops an extra for loop and ring index calculations ~= 300 gas reduction Assemblified the Validity Check ~= 700 gas reduction orderhelper - ValidateAllInfo is now all assembly ~= 750 gas reduction
Hephyrius
changed the title
|
Thanks, good change. It changes the data format a bit of the event so we'll see when we can merge this PR. |
|
It might be possible to keep the data in its current form/order with this change. I'll see if I can make that work and get back when/if it does. Edit: I reverted the order of the data, but managed to retain the packing savings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief: These changes are to the code present on the master branch as of 9th December 2018. They should be compatible with the latest commits, without clashes.
Note: Further smaller changes that reduce gas by providing minor changes to code, will be added to this commit.
Change Log: Compacted EmitRing event. This is done by storing values in a certain way. this allows 24 bytes are saved per ring. This equates to a roughly ~192 gas reduction per ring. Overall benchmark gas reduction ~ 500 gas
Original gas report:
Benchmark gas usage report:
simpleRingGas: 338677
typicalRingGas: 361322
p2pRingGas: 354619
multiRingGas: 528694
average: 395828
Gas after optimisation:
Benchmark gas usage report:
simpleRingGas: 338220
typicalRingGas: 360929
p2pRingGas: 354225
multiRingGas: 527979
average: 395338
Gas Reduction: ~500 gas reduced
Tests: all 216 pass