Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] external libraries support. #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartoszek
Copy link

@bartoszek bartoszek commented Dec 14, 2021

I've recently encountered a problem with bundled openvdb relying on deprecated tbb headers. Any chance for allowing building against external libs.

Suggested libs to "externalize" :

  • openvdb
  • opensubdiv
  • opencolorio
  • expat
  • yamlcpp

Header only libraries:

  • eigen
  • nohlman-json
  • spdlog

I've concocted an example for openvdb, woks for luxcorerender_v2.5 against openvdg:9.0.0

Resolves #572

@acasta69
Copy link
Member

The build failed, apparently only for Windows but really for all platforms. I think the reason is that an external OpenVDB is not available here.
My opinion is that this could be accepted, but I would suggest to reverse the logic, so that if we do nothing, i.e. no additional symbol is defined, the build is done with the bundled OpenVDB. If someone has a separate OpenVDB, they can define the symbol to have it used.
Of course we can only support the bundled version if something does not work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tbb API support.
2 participants