Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial static typing refactor #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Initial static typing refactor #5

wants to merge 9 commits into from

Commits on Aug 11, 2023

  1. tox: Add & configure mypy static type checking

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c64b910 View commit details
    Browse the repository at this point in the history

  2. Override dmypy with mypy in ms-python.mypy-type-checker extension

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f53ea8f View commit details
    Browse the repository at this point in the history

  3. Add ms-python.mypy-type-checker to recommended extensions

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9f421ee View commit details
    Browse the repository at this point in the history

  4. Add Config class module

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d2b579d View commit details
    Browse the repository at this point in the history

  5. Add type annotations to last few Config functions

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4c3a973 View commit details
    Browse the repository at this point in the history

  6. Config(): Fix bool comparison to match types (mypy --strict) 

    MyPy warning was:

    src/waybar_check_gmail/config/config.py:73:20:73:46: error: Non-overlapping identity check (left operand type: "Union[str, bool, None]", right operand type: "Type[bool]")  [comparison-overlap]
                        if self._map[sec][key] is bool:
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    Found 1 error in 1 file (checked 1 source file)
    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f5c3673 View commit details
    Browse the repository at this point in the history

  7. Document MyPy usage & add requirements-dev.txt

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d98adc0 View commit details
    Browse the repository at this point in the history

  8. Add version helper module

    @trinitronx
    trinitronx committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    efa0426 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. tox: remove duplicate quoting workaround for ymyzk/run-tox-gh-actions#6 

    Fixed in ymyzk/run-tox-gh-actions#7
    @trinitronx
    trinitronx committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    f8aa0e0 View commit details
    Browse the repository at this point in the history