Improvements to point-size slider #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this debouncing improves things enough so that the browser page doesn't lock up. However it's still not ideal.
The granularity of the point slider is controlled in the jquery-ui implementation. To give the illusion of greater granularity, increasing the range, and dividing the value by 2 before drawing the points. Addresses #21
It looks cool for the point size to change interactively when the user moves the slider. And for small numbers of points it responds just fine. So only use debouncing on the slider when there are many points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues related to the point-size slider. This PR will address some of these.