-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinction between max payload and max pax #81
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 73.41% 73.19% -0.23%
==========================================
Files 77 80 +3
Lines 13908 13459 -449
==========================================
- Hits 10211 9851 -360
+ Misses 3697 3608 -89 ☔ View full report in Codecov by Sentry. |
Thanks @argonaut22. Unfortunately, it seems like you reviewed the diffs in a merge commit from main, instead of the overall diffs in the PR! In essence, commit (2e87f30) contains diffs from older PRs already in TASOPT that I was merging into this branch to resolve merge conflicts. Could you please review the actual changes in this PR? You can do it by going to the "Files changed" tab. It should be very short as I didn't add a lot of code. |
This PR is a revived form of PR #63. It introduces the
exit_limit
as a way to specify the maximum number of seats in the cabin. This is stored as a field infuselage.cabin
. In addition, the name of the inputmax_pax
is changed to the more accuratemax_payload_in_pax_equivalent
.The code now uses the exit limit to resize the fuselage where appropriate. The PR also fixes a very minor bug in the double-decker case (a
parg
parameter had been left behind).