Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise get functions & (minor) fix typos in the comments #185

Merged
merged 4 commits into from
May 18, 2024
Merged

Revise get functions & (minor) fix typos in the comments #185

merged 4 commits into from
May 18, 2024

Conversation

LimHyungTae
Copy link
Member

@LimHyungTae LimHyungTae commented May 16, 2024

This PR is a bit subtle, but I revised the functions.

  • 040a6a3: By my mistake, getNormals was wrongly put as a private function. So I move the place
  • e3d6374: Add the getInputOrderedTranslationInliers function to easily visualize the actual inliers after the whole pipeline.
  • 3299678: By my silly mistake, I noticed that it should have been written as Quatro, but it remained as FGR due to copy and modification of the comments (here. While I modifying that typo, I also checked typos in the include folder and upload them

@LimHyungTae
Copy link
Member Author

LimHyungTae commented May 16, 2024

input_ordered_inliers
To better understand, I simply drew what getInputOrderedTranslationInliers is for as an example (see e3d6374). In turn, a user might want to get {1, 2, 7}, which corresponds to the order of raw src (or tgt), not {0, 1, 3}, which is returned by the getTranslationInliers function.

Copy link
Member

@jingnanshi jingnanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jingnanshi jingnanshi merged commit 9ca20d9 into MIT-SPARK:master May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants