Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove affordance to clear search terms #177

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Apr 25, 2024

Why these changes are being introduced:

UXWS changed their mind on this feature. They believe it's likely to be confusing.

Relevant ticket(s):

How this addresses that need:

This removes the 'clear' button from the search form and resets the CSS accordingly.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

Form display should now be identical to GeoData prod.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

UXWS changed their mind on this feature. They believe it's likely
to be confusing.

Relevant ticket(s):

* [GDT-244](https://mitlibraries.atlassian.net/browse/GDT-244)

How this addresses that need:

This removes the 'clear' button from the search form and resets
the CSS accordingly.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-244-re-7aqgxu April 25, 2024 13:01 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8833075316

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.456%

Totals Coverage Status
Change from base Build 8788892631: 0.0%
Covered Lines: 548
Relevant Lines: 551

💛 - Coveralls

@JPrevost JPrevost self-assigned this Apr 25, 2024
@jazairi jazairi merged commit 030e8ea into main Apr 25, 2024
5 checks passed
@jazairi jazairi deleted the gdt-244-remove-clear-button branch April 25, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants