Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel search highlights heading #181

Merged
merged 1 commit into from
May 1, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Apr 30, 2024

Why these changes are being introduced:

Usability testing indicated that the current search highlights heading may be confusing to some users.

Relevant ticket(s):

How this addresses that need:

This relabels the heading as suggested by UXWS.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

N/A

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

Usability testing indicated that the current search highlights
heading may be confusing to some users.

Relevant ticket(s):

* [GDT-305](https://mitlibraries.atlassian.net/browse/GDT-305)

How this addresses that need:

This relabels the heading as suggested by UXWS.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-305-re-914zos April 30, 2024 13:57 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8896071212

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.748%

Totals Coverage Status
Change from base Build 8884857321: 0.0%
Covered Lines: 552
Relevant Lines: 559

💛 - Coveralls

@jazairi jazairi requested review from JPrevost and matt-bernhardt and removed request for JPrevost and matt-bernhardt April 30, 2024 15:05
@jazairi
Copy link
Contributor Author

jazairi commented May 1, 2024

Merging this without review since it's a small change to some copy. Post-merge review is welcome.

@jazairi jazairi merged commit 3b4715f into main May 1, 2024
5 checks passed
@jazairi jazairi deleted the gdt-305-relabel-highlights-heading branch May 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants